search

chilipeppr / serial-port-json-server

Serial Port JSON Server is a websocket server for your serial devices. It compiles to a binary for Windows, Mac, Linux, Raspberry Pi, or BeagleBone Black that lets you communicate with your serial port from a web application. This enables web apps to be written that can communicate with your local serial device such as an Arduino, CNC controller, or any device that communicates over the serial port.
http://chilipeppr.com
GNU General Public License v2.0
321 stars 101 forks source link

Reorganize code #33

Open DanielJoyce opened 7 years ago

DanielJoyce commented 7 years ago

Project is large enough code should be broken out into modules now.

chilipeppr commented 7 years ago

Sounds like a decent idea. If you want to tackle some of it or for me to review or bounce ideas, I'm game. You could also check out how the arduino guys changed things in spjs for their project.

On Apr 24, 2017 4:35 PM, "Daniel" notifications@github.com wrote:

Project is large enough code should be broken out into modules now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/serial-port-json-server/issues/33, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbQ5huUavYp6xBy9s4Iqnpck4Q1dmks5rzTGngaJpZM4NG1ab .

DanielJoyce commented 7 years ago

Mostly put functionality in its own modules, such as Bufferflow, Cayenne, etc.

chilipeppr commented 7 years ago

Yeah, that makes sense.

On Tue, Apr 25, 2017 at 9:13 AM, Daniel notifications@github.com wrote:

Mostly put functionality in its own modules, such as Bufferflow, Cayenne, etc.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/serial-port-json-server/issues/33#issuecomment-297082377, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbTeeaA13csi9RSX7U9Z5s8a02xGkks5rzhulgaJpZM4NG1ab .

DanielJoyce commented 7 years ago

Oh geez, theres a ton of globals in the code.

chilipeppr commented 7 years ago

Indeed there are. It made things really easy at first, but yes, as project grew those could confuse new folks editing code.

On Tue, Apr 25, 2017 at 9:38 AM, Daniel notifications@github.com wrote:

Oh geez, theres a ton of globals in the code.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/serial-port-json-server/issues/33#issuecomment-297089613, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbdpR-Rs4oaKnWJNJLeT_z5KRmzzzks5rziF-gaJpZM4NG1ab .

DanielJoyce commented 7 years ago

Started chewing on this. Its a bit of a big knot but not bad.