search

chilipeppr / widget-3dviewer

The amazing 3D viewer that is the centerpiece of ChiliPeppr. It knows how to parse Gcode to show it as a 3D representation. Has a simulator built in for the tool path. Also has numerous pubsub signals defined to enable 3rd party tools to inject 3D objects into the viewer.
16 stars 41 forks source link

Major update to 3dviewer, update threejs and migrate all deprecated logic #12

Closed dchote closed 6 years ago

dchote commented 7 years ago

Hi John, I think this is ready for a review and merge if you want to take a look.

Now using the latest THREE.js, and have tested on my CNC.

I have not tested how other plugins may be impacted, but its working great in my workspace. http://chilipeppr.com/dchote

chilipeppr commented 7 years ago

In checking out your workspace, you are loading the Touch Plate widget, which may, or may not, load the three.js dependency before your 3d viewer does, but that would be random just based on browser loading order of operations of external files. So, you may find inconsistencies in the future based on that randomness.

On Sun, May 7, 2017 at 11:42 AM, Daniel Chote notifications@github.com wrote:

Reopened #12 https://github.com/chilipeppr/widget-3dviewer/pull/12.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-3dviewer/pull/12#event-1071963333, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbWkLv-_Hi9kWunlpOLQPLtMHfOmUks5r3hCsgaJpZM4NTQEk .