search

chilipeppr / widget-eagle

Eagle BRD Import widget for ChiliPeppr. Mill, solder mask creation, solder paste dispense, pick and place.
7 stars 23 forks source link

Version 5.4 #29

Closed ameennihad closed 7 years ago

ameennihad commented 7 years ago

Please check changelog.txt for list of new features and fixes.

ameennihad commented 7 years ago

Just noticed a bug in pads diameter, it's due to "this" "that" conflict, shall I do another pull request or you can fix it? following is the code that requires change (starting at line 6669): var diameter; if (that.activeLayer == "Top") diameter = pad.diameterTop; else if (that.activeLayer == "Bottom")
diameter = pad.diameterbottom;

chilipeppr commented 7 years ago

Hmm. I could try to keep this note in the back of my head, but a pull request could help me make sure I don't miss it.

On Fri, Feb 17, 2017 at 9:01 AM, ameennihad notifications@github.com wrote:

Just noticed a bug in pads diameter, it's due to "this" "that" conflict, shall I do another pull request or you can fix it? following is the code that requires change (starting at line 6669): var diameter; if (that.activeLayer == "Top") diameter = pad.diameterTop; else if (that.activeLayer == "Bottom") diameter = pad.diameterbottom;

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-eagle/pull/29#issuecomment-280706584, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbat_nyp6Bd1fSFE1JBuLPOMC1Uwrks5rddJlgaJpZM4MED0Y .

ameennihad commented 7 years ago

I believe the fix is automatically pushed to this request.

chilipeppr commented 7 years ago

Ok, cool.

On Fri, Feb 17, 2017 at 10:27 AM, ameennihad notifications@github.com wrote:

I believe the fix is automatically pushed to this request.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-eagle/pull/29#issuecomment-280728570, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbdonR8yd40xAZlCKdyJC-uwsp2ngks5rdeaVgaJpZM4MED0Y .