search

chilipeppr / widget-spjs

The essential widget if you want your workspace to talk to the Serial Port JSON Server (SPJS). This widget enables numerous pubsub signals so you can publish to SPJS and receive data back when you subscribe to the appropriate signals.
12 stars 33 forks source link

Added Arduino Mega & Mega Clone Support to spjs Widget #5

Closed robZeilinga closed 7 years ago

robZeilinga commented 7 years ago

Hi all, First ever community edit :)

Added new collection items to deviceMeta Collection

Please review names of boards i have chosen.

I am not sure of the purpose of the regex field in the collection item, i have commented these out for the two boards i have added.

Board Image for Clone Added megaCh340.jpg to this fork. This should be actually be located in the Chilipeppr.com/img/boards folder. (the image path in widget.js points there).

Testing : Copied spjs widget and placed in workspace chilipeppr.com/robz1
all working (apart from display of image)

mega support added

clone support added

Thanks for the awesome project.

chilipeppr commented 7 years ago

So, my only concern on this change is the CH340 chip is a generic usb to serial chip that is used in tons of devices. So I think labelling it as Arduino Mega clone is not a safe way to go. I have NodeMCU's that use CH340's. I think it's safer to leave this as generic CH340.

Now, for your official Arduino Mega2560, that does seem to have a set VID/PID from doing a Google search. I think that's a good change.

Thoughts?

On Fri, Jan 13, 2017 at 10:11 AM, Rob Zeilinga notifications@github.com wrote:

Hi all, First ever community edit :)

Added new collection items to deviceMeta Collection

  • Arduino Mega 2560 : [{vid:"2341", pid:"0042"}]
  • Mega 2560 Chinese Clones (CH340) : [{vid:"1A86", pid:"7523"}]

Please review names of boards i have chosen.

I am not sure of the purpose of the regex field in the collection item, i have commented these out for the two boards i have added.

Board Image for Clone Added megaCh340.jpg to this fork. This should be actually be located in the Chilipeppr.com/img/boards folder. (the image path in widget.js points there).

Testing : Copied spjs widget and placed in workspace chilipeppr.com/robz1 all working (apart from display of image)

Thanks for the awesome project.

You can view, comment on, or merge this pull request online at:

https://github.com/chilipeppr/widget-spjs/pull/5 Commit Summary

  • Made some changes to ChiliPeppr widget using Cloud9
  • Made some changes to ChiliPeppr widget using Cloud9

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-spjs/pull/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbSKqrFomRLJEHjNS3PlzX_16qoHuks5rR75IgaJpZM4LjJmD .

robZeilinga commented 7 years ago

100% agree. I will attempt to retract the pull request and only look for the Arduino Mega

On 14 Jan 2017 03:43, "John Lauer" notifications@github.com wrote:

So, my only concern on this change is the CH340 chip is a generic usb to serial chip that is used in tons of devices. So I think labelling it as Arduino Mega clone is not a safe way to go. I have NodeMCU's that use CH340's. I think it's safer to leave this as generic CH340.

Now, for your official Arduino Mega2560, that does seem to have a set VID/PID from doing a Google search. I think that's a good change.

Thoughts?

On Fri, Jan 13, 2017 at 10:11 AM, Rob Zeilinga notifications@github.com wrote:

Hi all, First ever community edit :)

Added new collection items to deviceMeta Collection

  • Arduino Mega 2560 : [{vid:"2341", pid:"0042"}]
  • Mega 2560 Chinese Clones (CH340) : [{vid:"1A86", pid:"7523"}]

Please review names of boards i have chosen.

I am not sure of the purpose of the regex field in the collection item, i have commented these out for the two boards i have added.

Board Image for Clone Added megaCh340.jpg to this fork. This should be actually be located in the Chilipeppr.com/img/boards folder. (the image path in widget.js points there).

Testing : Copied spjs widget and placed in workspace chilipeppr.com/robz1 all working (apart from display of image)

Thanks for the awesome project.

You can view, comment on, or merge this pull request online at:

https://github.com/chilipeppr/widget-spjs/pull/5 Commit Summary

  • Made some changes to ChiliPeppr widget using Cloud9
  • Made some changes to ChiliPeppr widget using Cloud9

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-spjs/pull/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbSKqr FomRLJEHjNS3PlzX_16qoHuks5rR75IgaJpZM4LjJmD .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-spjs/pull/5#issuecomment-272591536, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxvRukPon8Z3WZxQC1mr_dbBKrayj8bks5rSCgmgaJpZM4LjJmD .

robZeilinga commented 7 years ago

100% - was going to update pull request - but i see you've already done the necessary. (sorry for delay - work / life / cnc balance not quite there yet! )

thanks

On Sat, Jan 14, 2017 at 3:46 AM, John Lauer notifications@github.com wrote:

Merged #5 https://github.com/chilipeppr/widget-spjs/pull/5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-spjs/pull/5#event-923062165, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxvRg33qZUdjyPe4YWVYncR16gNVl7yks5rSCjngaJpZM4LjJmD .