feat!: Tighten typing for callbacks

chill-chinese / stroke-order-animator

Stroke order animations and quizzes for Chinese characters in Flutter.

https://chill-chinese.github.io/stroke-order-animator/

BSD 3-Clause "New" or "Revised" License

87 stars 24 forks source link

feat!: Tighten typing for callbacks #62

Closed Mr-Pepe closed 10 months ago

Mr-Pepe commented 10 months ago

This is a breaking change.

Callbacks were typed as Function which is too broad. This change tightens the types to void Function(QuizSummary) and void Function(int). Furthermore, the methods for adding callbacks do not accept null anymore.

Mr-Pepe commented 10 months ago

Current dependencies on/for this PR:

main
- PR #57
- PR #58
  - PR #59
  - PR #60
    - PR #61
    - PR #62 👈
      - PR #63
      - PR #64
        
        PR #65

This stack of pull requests is managed by Graphite.

Mr-Pepe commented 10 months ago

Merge activity

Jan 12, 7:50 AM: @Mr-Pepe started a stack merge that includes this pull request via Graphite.
Jan 12, 8:00 AM: Graphite rebased this pull request as part of a merge.
Jan 12, 8:01 AM: @Mr-Pepe merged this pull request with Graphite.