search

chill-chinese / stroke-order-animator

Stroke order animations and quizzes for Chinese characters in Flutter.
https://chill-chinese.github.io/stroke-order-animator/
BSD 3-Clause "New" or "Revised" License
87 stars 24 forks source link

fix: Improve animations when background is enabled #90

Closed Mr-Pepe closed 5 months ago

Mr-Pepe commented 5 months ago

There were some issues with how the strokes where overlapping each other when the background was enabled. While I was at it, I refactored and optimized the whole drawing part of the stroke order animations.

Mr-Pepe commented 5 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Mr-Pepe and the rest of your teammates on Graphite Graphite

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 74.05660% with 55 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (3d3a093) to head (f6dedd1). Report is 1 commits behind head on main.

Files Patch % Lines
lib/src/character_painter.dart 79.59% 30 Missing :warning:
lib/src/stroke_order_animator.dart 47.91% 25 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== - Coverage 72.94% 71.66% -1.28% ========================================== Files 6 8 +2 Lines 499 533 +34 ========================================== + Hits 364 382 +18 - Misses 135 151 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Mr-Pepe commented 5 months ago

LGTM