search

chill-chinese / stroke-order-animator

Stroke order animations and quizzes for Chinese characters in Flutter.
https://chill-chinese.github.io/stroke-order-animator/
BSD 3-Clause "New" or "Revised" License
86 stars 22 forks source link

feat: Remove `provider` dependency #92

Closed Mr-Pepe closed 3 months ago

Mr-Pepe commented 3 months ago

The StrokeOrderAnimator now uses a ListenableBuilder to directly listen to the StrokeOrderAnimationController. This removes the need for a ChangeNotifierProvider and Consumer.

Mr-Pepe commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Mr-Pepe and the rest of your teammates on Graphite Graphite

Mr-Pepe commented 3 months ago

LGTM

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (36f6c41) to head (4213801).

Files Patch % Lines
lib/src/stroke_order_animator.dart 39.28% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ========================================== - Coverage 72.28% 71.85% -0.43% ========================================== Files 8 8 Lines 534 533 -1 ========================================== - Hits 386 383 -3 - Misses 148 150 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Mr-Pepe commented 3 months ago

Merge activity