search

chill117 / lnurl-node

Flexible lnurl server implementation with API and CLI implemented in nodejs.
MIT License
97 stars 26 forks source link

remove `successAction` #43

Closed fiatjaf closed 3 years ago

fiatjaf commented 3 years ago

It being null breaks some wallets, better just not send it.

chill117 commented 3 years ago

Shouldn't those wallets fix their poor JSON parsing? The base lnurl pay spec says:

Once payment is fulfilled LN WALLET executes a non-null successAction. For message, a toaster or popup is sufficient. For url, the wallet should give the user a popup which displays description, url, and a 'open' button to open the url in a new browser tab. For aes, LN WALLET must attempt to decrypt a ciphertext with payment preimage. LN WALLET should also store successAction data on the transaction record.

This says to me that successAction can be null - in which case wallets should ignore it.