Codecov Report

Merging #172 (6bca964) into main (7fd54b7) will decrease coverage by 0.03%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #172      +/-   ##
============================================
- Coverage     90.18%   90.15%   -0.04%     
  Complexity     1083     1083              
============================================
  Files            44       44              
  Lines          2528     2519       -9     
============================================
- Hits           2280     2271       -9     
  Misses          248      248

Impacted Files	Coverage Δ
src/Output/QRMarkupHTML.php	`94.11% <ø> (ø)`
src/Detector/Detector.php	`90.07% <0.00%> (-0.08%)`	:arrow_down:
src/Data/QRMatrix.php	`100.00% <0.00%> (ø)`
src/Common/EccLevel.php	`100.00% <0.00%> (ø)`
src/Common/MaskPattern.php	`100.00% <0.00%> (ø)`
src/Decoder/GDLuminanceSource.php	`100.00% <0.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codemasher commented 1 year ago

Oh my this is missing since forever! Guess nobody has been using HTML file output so far... 🥲 https://github.com/chillerlan/php-qrcode/blob/c4bbb199b3b218f8691a6f748b3d5a05f0a950b8/src/Output/QRMarkup.php#L77-L79 https://github.com/chillerlan/php-qrcode/blob/34dff2816dff2339206ad6a400d97578083690d3/src/Output/QRMarkup.php#L76 https://github.com/chillerlan/php-qrcode/blob/bf0382aaf2f79fa41c2dcb0f216675f74d633fe7/src/Output/QRMarkup.php#L41 (also reminder to self to disable the doc build for PRs)

codemasher commented 1 year ago

Just on a side note, the Mozilla article says:

While HTML does not require authors to specify <html> element start and ending tags, [...]

So apparently it's been fine all along.

chillerlan / php-qrcode

The 'html' tag is missing in HTML output #172

Codecov Report