chillerlan / php-qrcode

A PHP QR Code generator and reader with a user-friendly API.
https://smiley.codes/qrcode/
Apache License 2.0
2.01k stars 302 forks source link

Added Fpdf output #49

Closed MaximilianKresse closed 4 years ago

MaximilianKresse commented 4 years ago

See #48

codecov-commenter commented 4 years ago

Codecov Report

Merging #49 into master will decrease coverage by 3.87%. The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master      #49      +/-   ##
=============================================
- Coverage     100.00%   96.12%   -3.88%     
- Complexity       312      325      +13     
=============================================
  Files             16       17       +1     
  Lines            720      749      +29     
=============================================
  Hits             720      720              
- Misses             0       29      +29     
Impacted Files Coverage Δ Complexity Δ
src/Output/QRFpdf.php 0.00% <0.00%> (ø) 13.00 <13.00> (?)
src/QRCode.php 100.00% <ø> (ø) 29.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e1c765...c7a7016. Read the comment docs.

codemasher commented 4 years ago

Hey! Thank you so much for your contribution! It looks good so far, only a few minor things (code style, declare, file docblock) i'd fix after merge if that's ok for you.

MaximilianKresse commented 4 years ago

Sure :-)