chilli-axe / mpc-autofill

Print automation software (leveraging MakePlayingCards) for your tabletop gaming community
https://mpcautofill.github.io
GNU General Public License v3.0
220 stars 97 forks source link

Flesh out tags system + track card languages #167

Closed ndepaola closed 1 year ago

ndepaola commented 1 year ago

Description

Checklist

glandu-sr commented 1 year ago

Forgot to add that the naming conventions in the Contributors page will need to be updated.

ndepaola commented 1 year ago

To be sure I understand correctly, if I have a folder named <FR>White(NSFW) and a card named Mountain(Artist Name)[Alt], I will have a Mountain card, named Mountain(Artist Name) in the FR language with the tags Nsfw and Alt Art ? Does it just take the direct parent folder or all parent folders ? And what happens if I have and FR folder and put a <DE>Island in it ? Will it be DE or FR ?

Otherwise, great improvements of my tags PR.

the intended behaviour is:

upon thinking about it now, i realise my current approach might not capture all of these corner cases - i'll take another look at this code today to double check

thank you for the review btw!