Closed ndepaola closed 1 year ago
Forgot to add that the naming conventions in the Contributors page will need to be updated.
To be sure I understand correctly, if I have a folder named
<FR>White(NSFW)
and a card namedMountain(Artist Name)[Alt]
, I will have aMountain
card, namedMountain(Artist Name)
in theFR
language with the tagsNsfw
andAlt Art
? Does it just take the direct parent folder or all parent folders ? And what happens if I have and FR folder and put a<DE>Island
in it ? Will it be DE or FR ?Otherwise, great improvements of my tags PR.
the intended behaviour is:
<FR>
<EN>
DE
upon thinking about it now, i realise my current approach might not capture all of these corner cases - i'll take another look at this code today to double check
thank you for the review btw!
Description
Tag
table<EN> card name.png
Checklist
pre-commit
and run the hooks withpre-commit run
.