chilli-axe / mpc-autofill

Print automation software (leveraging MakePlayingCards) for your tabletop gaming community
https://mpcautofill.github.io
GNU General Public License v3.0
206 stars 93 forks source link

Server Error for Moxfield decks #197

Closed jdstamp closed 9 months ago

jdstamp commented 9 months ago

System

Affected Components

Description

When I go to either mpcfill.com or mpcautofill.github.io/editor and use a moxfield link (e.g. https://www.moxfield.com/decks/j-0aJlxuOUm9FnKRvJcfZw ) to add cards I get a "Server Error", see screenshot below.

image

The expected behaviour is that the editor loads the card list.

Steps to Reproduce

Open mpcautofill.github.io/editor and click "add cards > url" and paste any moxfield link.

This problem has been reproduced both on mpcfill.com and mpcautofill.github.io with firefox and safari.

jdstamp commented 9 months ago

Other websites i tried work as expected (e.g. tappedout, mtggoldfish)

ndepaola commented 9 months ago

howdy - thanks for reporting this and sorry for the inconvenience! i also noticed it was broken the other day and fixed it in this commit 478e7995a702986ba77d1fcbc20553db75c8d08a (i think it's fine to use request headers like this since we're not scraping their site, but rather we are querying data on a user's behalf)

ndepaola commented 9 months ago

looks like this has broken again - imma reach out to the moxfield team and see what we can do

ndepaola commented 9 months ago

properly fixed by 9879a5e090ca040be7369c7aaaa390254156bcd1

bwsinger commented 9 months ago

I'm still seeing this issue with Moxfield URLs.

image

Payload:

{url: "https://www.moxfield.com/decks/hHcoQkbo2kWxXSCNyXGX5A"}
ndepaola commented 9 months ago

I'm still seeing this issue with Moxfield URLs.

image

Payload:

{url: "https://www.moxfield.com/decks/hHcoQkbo2kWxXSCNyXGX5A"}

yep i hear you - to clarify, the software fix is done but the change hasn't been pulled into mpcfill.com yet. you're looking for https://github.com/Investigamer/mpc-fill/pull/9

bwsinger commented 9 months ago

Gotcha. I noticed that the x-reauested-by header wasn't passed. I'm glad it's all good.

image
NagashSzarekh commented 7 months ago

This bug still appears to exist do we have any timeline on when the fix will be pulled into mpcfill.com or mpcautofill.github.io?

ndepaola commented 7 months ago

This bug still appears to exist do we have any timeline on when the fix will be pulled into mpcfill.com or mpcautofill.github.io?

i totally hear your frustration but the correct place to ask this is https://github.com/Investigamer/mpc-fill/pull/9, not here - i have no control over mpcfill.com