chilli-axe / mpc-autofill

Print automation software (leveraging MakePlayingCards) for your tabletop gaming community

https://mpcautofill.github.io

GNU General Public License v3.0

220 stars 97 forks source link

✨ Load a wiki page after Selenium is initialized to remind the user to look back at the terminal to answer more questions #242

Closed coderanger closed 5 months ago

coderanger commented 5 months ago

Description

I set the page to Desktop-Tool-Landing but it can be whatever. Some example content (because wikis don't accept PRs):

# Congratulations!

MPCAutofill has started successfully, please look back at your terminal window to answer a few more questions before the upload can begin.

Check out [the documentation if you have any further questions](Desktop-Tool).

Checklist

[x] I have installed pre-commit and installed the hooks with pre-commit install before creating any commits.
[ ] I have updated any related tests for code I modified or added new tests where appropriate.
[x] I have manually tested my changes as follows:
- Ran autofill.py and observed it working.
[ ] I have updated any relevant documentation or created new documentation where appropriate.

ndepaola commented 5 months ago

thanks for getting the ball rolling on this! i've been meaning to make this change for a few weeks but didn't get around to it.

after some more thought, i think it would be better to load a local HTML page rather than loading a page hosted in the wiki - a) because it means the page should load instantly, and b) because it doesn't really belong in the wiki.

would you mind taking a look at whether it's possible to point selenium at a local HTML file? you may also need to update the pyinstaller build to include the new file

coderanger commented 5 months ago

Surely, if you want to go even further it could be a localhost webserver and move the config from terminal into a UI? That might be too much though :)

coderanger commented 5 months ago

I split the difference, it's setup on an internal web server but just a single static page for now.

coderanger commented 5 months ago

Is the test failure real? Seems unrelated in the PDF functionality and those tests haven't been run in a while. I can look tomorrow or something.

ndepaola commented 5 months ago

Surely, if you want to go even further it could be a localhost webserver and move the config from terminal into a UI? That might be too much though :)

we certainly could do yea - though i think it's out of scope here. let's roll with the local webserver approach you have for now and come back to reworking the UI later

Is the test failure real? Seems unrelated in the PDF functionality and those tests haven't been run in a while. I can look tomorrow or something.

it looks like this is because you haven't set up your repo fork with google drive credentials. this is touched on here https://github.com/chilli-axe/mpc-autofill/wiki#contributing but it looks like the docs are a bit out of date - this now matters when modifying desktop tool code as well as backed code. i'll update the docs in a sec to clarify this

the tests failing isn't a big deal at all, they'll rerun with my google drive credentials after i merge the PR anyway

ndepaola commented 5 months ago

merging w/ unresolved comment, i'll fix this bit up