search

chilli-axe / mtg-photoshop-automation

Photoshop scripting to generate high-quality Magic card renders, inserting Scryfall data into Photoshop frame templates.
GNU General Public License v3.0
60 stars 39 forks source link

Multiple reminder text, only one italicized #34

Closed Investigamer closed 2 years ago

Investigamer commented 2 years ago

Someone brought to my attention that cards with two separate instances of reminder text will only render the first text in italics but not the second, I've included an example image. Trying to find other cards to replicate this with but I don't think there are many cards with this situation Timeless Dragon

Investigamer commented 2 years ago

Apparently its not solely due to there being two separate reminder text and related to some other issue, because Ardent Plea renders correctly: Ardent Plea

Any ideas?

ndepaola commented 2 years ago

this was occurring due to the reminder text for eternalise having 2 instances of {W}, and only the first instance was being replaced with ow (the font representation of that symbol) when identifying the start/end indices of the italics string within the body of text. Root cause was string.replace only replacing the first instance of the specified substring, not all instances. it can be reproduced with other cards that have multiple instances of the same symbol within italics symbols - e.g. most eternalise cards. fixed in https://github.com/chilli-axe/mtg-photoshop-automation/commit/bd5d4095a172f8c5dbcbf50e6b5e1833bbebe806 by using regex to replace all instances.