chilts / awssum

(deprecated: use aws-sdk) Node.js modules for talking to lots of Web Service APIs.
Other
462 stars 57 forks source link

add support for versioning on S3 #140

Open techtribe opened 11 years ago

techtribe commented 11 years ago

enabled support for unrequired resource-variables like versioning (on S3).

techtribe commented 11 years ago

While I couldn't find any examples for s3.PutBucketAcl & s3.PutBucketCors (which are the only ones that use "resource" as non-required parameter) that it would be a best practice to use the following structure if you want to add the "resource"-parameter to your request:

s3.ListObjects :

Versions:true = works
Versions:"true" = works
Versions:"false" = does not work
Versions:false = does not work
Versions:undefined = does not work

which will imply that examples for s3.PutBucketAcl & s3.PutBucketCors will need to have the above examples (how to enable an s3-put-bucket-example) to make it work.

@chilts are you okay with this approach, or do you have another solution? In the old/previous setup "required"-parameter was ignored (at awssum.js at line 501), so it was always sent even if you didn't put in the params-object in your request/call.

kriangkraikaewbappha commented 7 years ago

mQINBFh1XPABEADXorlGKWsNvc3woSZ