chilts / awssum

(deprecated: use aws-sdk) Node.js modules for talking to lots of Web Service APIs.
Other
462 stars 57 forks source link

PutBucketWebsite is missing ContentLength header to work on GreenQloud (fix included) #148

Closed sputnick closed 11 years ago

sputnick commented 11 years ago

Hey Andy,

I debugged PutBucketWebsite and just like the PutAcl methods it needs the content length. I added the extras option in line 1239 of s3-config.js and then it worked. We now have static website support from Storage Qloud buckets :) ... body : bodyWebsiteConfiguration, addExtras : extrasContentLength, ...

Can you make that one line change in master?

cheers Eiki GreenQloud

sputnick commented 11 years ago

It would be great to get this into master asap so we can update our servers...

cheers Eiki

chilts commented 11 years ago

Hi Eiki,

It's such a minor change ... but it would be quicker if you were to create a pull request.

I'm currently working pretty long hours on something I get paid to do. They have my attention and priority. This is an unpaid project I work on on the side. If you can help it from the point of view of a company using it to make money, then a pull request would be greatly appreciated. :)

Cheers, Andy

sputnick commented 11 years ago

Will do buddy :)

Eirikur Hrafnsson - @EirikurH Founder & Chief Global Strategist @GreenQloud - http://greenqloud.com

On 27.1.2013, at 23:19, Andrew Chilton notifications@github.com wrote:

Hi Eiki,

It's such a minor change ... but it would be quicker if you were to create a pull request.

I'm currently working pretty long hours on something I get paid to do. They have my attention and priority. This is an unpaid project I work on on the side. If you can help it from the point of view of a company using it to make money, then a pull request would be greatly appreciated. :)

Cheers, Andy

— Reply to this email directly or view it on GitHub.

chilts commented 11 years ago

Fixed in the new awssum/awssum-amazon-s3.

Released as v1.0.1.