search

chilts / mongodb-queue

Message queues which uses MongoDB.
209 stars 91 forks source link

Consider adding this .update function #3

Closed msageryd closed 8 years ago

msageryd commented 9 years ago

Mongodb-queue is a nice little queue handler. I missed being able to update the payload for open tasks, though.

Please consider pulling my version:

msageryd commented 9 years ago

I'm adding some more functions in my fork. One is the ability to keep tasks on hold until explicitly released. The .add function also gets ability to add tasks with hold flag set from start.

I'd like to know if you want to pull updates. Otherwise I won't put time into updating documentation and and polishing my commits. For now I'm letting my fork diverge for personal use. Please get back to me if I should issue more pull requests.

Thank you for a great foundation for my queue needs.

chilts commented 9 years ago

Hi @michaelswe. Thanks for this. Am just acknowledging the PR though I haven't looked at it yet. Just from your quick description, I'm not sure I'd want to be able to explicitly hold on to tasks but I could be convinced if it's optional.

I'll go read your code to figure out what you mean by updating the payload. If I understand correctly, I'd probably suggest that should be a separate queue with new data for a different process to deal with - but again, I'll keep an open mind and look over your code. :)

Anyway, thanks again and am glad you've got a good foundation out of it.

chilts commented 9 years ago

Ah, this is just for the update. Feel free to open any other issues with your other functionalty if you like so each issue is a separate topic. :)

chilts commented 8 years ago

Thinking about it, being able to change the payload for open tasks isn't really what I think a queue should do. Going to close this but feel free to re-open with further arguments or examples.