chilts / nice-route53

A nicer API to Amazon's Route53.
Apache License 2.0
37 stars 20 forks source link

setRecord does not delete an existing record due to string mismatch #1

Closed jrgm closed 11 years ago

jrgm commented 11 years ago

You have a bug here - https://github.com/chilts/nice-route53/blob/master/nice-route53.js#L363-L385

The comparison is made between 'foo.bar.com' and 'foo.bar.com.' (with a trailing dot). So in trying to update an existing record, the DELETE is not done before the ADD in the changeset (which errors out).