search

chilts / nice-route53

A nicer API to Amazon's Route53.
Apache License 2.0
37 stars 20 forks source link

Fix handling of 'A' records, which were previously ignored. #3

Open EdJ opened 10 years ago

EdJ commented 10 years ago

In the current version of nice-route53 'A' records are not returned from the #records() call, as they do not contain a ResourceRecords entry, instead having an AliasTarget.

I have updated the tests and the code itself to handle this scenario, hope it's inline with your contribution format.

comster commented 6 years ago

Don't you have to remove the TTL argument as well?

EdJ commented 6 years ago

@comster good question. I wrote this PR nearly 3 years ago, but I seem to remember it working fine. I think the TTL may be set (line 102) but not in the test XML, which may be a little misleading.

Either way I'd be very surprised if this gets merged after all this time.