search

chilts / nice-route53

A nicer API to Amazon's Route53.
Apache License 2.0
37 stars 20 forks source link

fixed makeError(err) function #6

Closed leorossi closed 9 years ago

leorossi commented 9 years ago

That should be done in #5 but I forgot to!

Since now the error can come only from aws-sdk, I fixed the makeError function to return the message and the code from AWS.

chilts commented 9 years ago

Would you like me to add you as a collaborator on GitHub and a co-maintainer on npm? I'd be happy to do both. That way you can release as you see fit. :)

chilts commented 9 years ago

Released to npm as v1.0.1. Thanks again for your contributions.

leorossi commented 9 years ago

Hi Andrew,

yes please that will speed up the release process if there are improvements to the code!

Thanks for your offer, I really appreciate the trust!

Cheers!

Leonardo Rossi - Web Developer

www.leorossi.it www.linkedin.com/in/leorossi82

Skype: megamegabyte Public Key: https://keybase.io/leorossi/key.asc

On Wed, Aug 12, 2015 at 12:23 AM, Andrew Chilton notifications@github.com wrote:

Would you like me to add you as a collaborator on GitHub and a co-maintainer on npm? I'd be happy to do both. That way you can release as you see fit. :)

— Reply to this email directly or view it on GitHub https://github.com/chilts/nice-route53/pull/6#issuecomment-130095963.

chilts commented 9 years ago

Hi @leorossi, I've added you as a collaborator on this repo. :)

What's your npm username?

chilts commented 9 years ago

Ahah, I should have guessed : https://www.npmjs.com/~leorossi

leorossi commented 9 years ago

Yes you are right, that's me! :)

Leonardo Rossi - Web Developer

www.leorossi.it www.linkedin.com/in/leorossi82

Skype: megamegabyte Public Key: https://keybase.io/leorossi/key.asc

On Sat, Aug 15, 2015 at 11:04 AM, Andrew Chilton notifications@github.com wrote:

Ahah, I should have guessed : https://www.npmjs.com/~leorossi

— Reply to this email directly or view it on GitHub https://github.com/chilts/nice-route53/pull/6#issuecomment-131318906.

chilts commented 9 years ago

All done. You can now merge in here and release to npm. The only thing I ask is if you make a release with a particular version (say x.y.z) to make a tag here such as vx.y.z.

See git tag -l for the previous tags.

leorossi commented 9 years ago

Ok will do it!

Leonardo Rossi - Web Developer

www.leorossi.it www.linkedin.com/in/leorossi82

Skype: megamegabyte Public Key: https://keybase.io/leorossi/key.asc

On Sat, Aug 15, 2015 at 11:07 AM, Andrew Chilton notifications@github.com wrote:

All done. You can now merge in here and release to npm. The only thing I ask is if you make a release with a particular version (say x.y.z) to make a tag here such as vx.y.z.

See git tag -l for the previous tags.

— Reply to this email directly or view it on GitHub https://github.com/chilts/nice-route53/pull/6#issuecomment-131319089.

chilts commented 9 years ago

:+1: Thanks. Much appreciated for helping with this. :)