chilts / nice-route53

A nicer API to Amazon's Route53.
Apache License 2.0
37 stars 20 forks source link

Corrected IsTruncated handling in Route53.prototype.zones. #7

Closed lukeacl closed 9 years ago

lukeacl commented 9 years ago

The comparison for IsTruncated was === 'true' when it should have been === true, the returned type from the AWS-SDK is a boolean not a string. The rest of the IsTruncated comparisons in the file are boolean, this one might have been missed.

leorossi commented 9 years ago

Yes it has been missed for sure, my bad!

LGTM

chilts commented 9 years ago

Thanks @squarefanatic and @leorossi. :)