search

chime-experiment / ch_util

CHIME utilities
https://chime-experiment.github.io/ch_util
MIT License
2 stars 3 forks source link

fix(requirements): Bump peewee requirement to 3.14.1 or newer #28

Closed ketiltrout closed 2 years ago

ketiltrout commented 2 years ago

When using a layout.Component instance to look up a layout.Connexion we appear to have been affected by https://github.com/coleifer/peewee/issues/2304 which was fixed in Peewee 3.14.1.

This was most noticeable when using from_pair(comp1, comp2).

This bug is also the reason we had to make this fix: https://github.com/chime-experiment/ch_util_private/pull/34 (which didn't make any sense to me at the time)

Peewee-2 was not affected by this bug, which is why this code worked when we originally created the layout API.

jrs65 commented 2 years ago

Nice detective work!