search

chime-experiment / ch_util

CHIME utilities
https://chime-experiment.github.io/ch_util
MIT License
2 stars 3 forks source link

Determine feed positions of PCO using PCOAntenna #39

Closed lazdam closed 1 year ago

lazdam commented 2 years ago

See linked issue: #31

lazdam commented 2 years ago

Is there any way to check which version of black we're using? I have the latest, so if that causes the lint-code test to fail, I'll have to swap versions.

aaronpearlman commented 2 years ago

@lazdam I just approved and ran the checks. Everything passed. The lint checker is running with black-22.8.0. This looks good to me!

I think we're ready to merge it in once @jrs65 approves it.

lazdam commented 2 years ago

Sorry @lazdam, one quick last thing, can you change the commit message to follow the guidelines. Probably should be feat(tools): enable feed position calculation for outriggers. It's important for our changelog generation to have this format.

Also, please rebase on the latest master while you do so.

Otherwise, it looks great. Thanks! When you've made the changes I can merge immediately.

Should be done. Rebased with master and updated commit message.

aelanman commented 1 year ago

@jrs65 Is there anything more that needs to be done for this to be merged?

aelanman commented 1 year ago

Thanks @jrs65 !