search

chime-experiment / ch_util

CHIME utilities
https://chime-experiment.github.io/ch_util
MIT License
2 stars 3 forks source link

layout db: comments during "LTF import should be attached to the connections #6

Closed nritsche closed 1 year ago

nritsche commented 3 years ago

Originally from Adam Hincks: If you mean that comments in the LTF, i.e., lines starting with a hash (#) do not appear, that is in fact the intended behaviour. The only comment that should appear is the one in the comment line. That being said, it isn't a bad idea for comments in the LTF to propagate. I hadn't thought of it. Consider the following example:

CAN0000A
CXA0000A
LNA0000A

# Another comment.
CAN0000A attenuation=10

You would like the two connexion events to have the comment "Comment here", and the attenuation property event to have the comment "Another comment"? What about for the following:

# A comment.
CAN0000A attenuation=10
CXA0000A
LNA0000A

This would have the comment "A comment" for both the connexion and the property events. Would that be OK?

nritsche commented 3 years ago

comment originally from @mondana: correct. Comment "A comment" to appear on both connections would be ideal. This will facilitate having one LTF file for various connections made during the day with comments that apply to each part of the file separately. The problem with the comment in the "comment line" is that it is restrictive and hard to add multi-lines.