search

chime-experiment / ch_util

CHIME utilities
https://chime-experiment.github.io/ch_util
MIT License
3 stars 3 forks source link

fix(rfi): remove automatic timestemp set and move default instrument to argument #61

Closed ljgray closed 1 year ago

ljgray commented 1 year ago

Setting the default timestamp to time.time() would potentially break compatibility with the cosmology daily pipeline since the current time does not necessarily have any relation to the CSD being processed.

For example, if an old day did not provide a timestamp, a band which has turned off since then would not get flagged when using the current time as a timestamp even though the band was still active when that data was collected.

I'm not sure if using the current time is needed for outrigger masking - if so, it should probably be moved to a separate place so that we maintain compatibility with the analysis pipeline.

ljgray commented 1 year ago

Thanks! Originally it didn't support setting end times since I just assumed none of the bands would actually turn off... So the comparison would have been different and would have worked fine at that point using the current time.