search

chime-experiment / ch_util

CHIME utilities
https://chime-experiment.github.io/ch_util
MIT License
3 stars 3 forks source link

feat(hfbcat): Move get_doppler_shifted_freq from ephemeris #73

Closed ketiltrout closed 3 months ago

ketiltrout commented 3 months ago

This isn't going to go with the rest of the ephemeris code to the new repository, so let's put is somewhere else.

Weirdly, the original docstring for this function seems to indicate it was meant to go in tools, but since its hardcoded to work work only on the HFBCatalog putting it in hfbcat directly seems most intuitive.

The re-constituted stub in ephermis avoids the circular import.

ketiltrout commented 3 months ago

Looks good. I did a quick test and the function works as expected.

Thanks for fixing the docstring. I guess the function was developed in tools and I forgot to update the docstring when Richard recommended to put it in ephemeris.

I figured it must have been something like that.

I'm happy to leave get_range_rate in ephemeris.

I am, too. It seems generic enough.