chime-experiment / coco

A Config Controller
https://chime-coco.readthedocs.io/
GNU General Public License v3.0
3 stars 2 forks source link

Speed up reply<->state check #209

Closed nritsche closed 4 years ago

nritsche commented 4 years ago

Speeds up the kotekan config check by minimizing the number of DeepDiff calls.

There's a bit of refactoring and test additions to facilitate the change, but the commit messages hopefully make the review easy.

The two fix commits fix an issue discovered when adding the test.

Closes #161

anjakefala commented 4 years ago

I did not notice anything outside of the things Tristan has already commented on. =)

nritsche commented 4 years ago

Thanks for reviewing!