Closed aelanman closed 2 years ago
This pull request introduces 1 alert when merging ddea6e22f98a62292a408ac451c9a793b6eb5cb1 into 195e3597f63ad69273bffb87dcd3c33c320b3f58 - view on LGTM.com
new alerts:
This pull request introduces 1 alert when merging 42aa786de9dcff847c7a3b6986627fad9a843442 into 195e3597f63ad69273bffb87dcd3c33c320b3f58 - view on LGTM.com
new alerts:
This pull request introduces 1 alert when merging ab56c970f4e75b4b88d9869aa545c2f210e0f05f into 195e3597f63ad69273bffb87dcd3c33c320b3f58 - view on LGTM.com
new alerts:
This pull request introduces 1 alert when merging 429be51401371edc62ff70c366279d133a983ceb into 195e3597f63ad69273bffb87dcd3c33c320b3f58 - view on LGTM.com
new alerts:
Is there a timeline on getting this fixed? The aioredis version mismatch between coco and comet has broken the ch_ansible
checks and I'm wondering if it's worth spending time implementing a workaround for that.
I think the thing is waiting on at the moment is me to review it. Let me have a look at doing that now.
@jrs65 Sorry for the long wait -- I've addressed the main comment above, but I'm still not sure about that last failing test
@jrs65 This is now passing all the linting checks as well
@andrerenard @jrs65 Sorry it took me so long to get back to this. I didn't see that you'd replied. I think I've updated the commit messages correctly.
The CI seems to be having some issue finding a good pylint version. Playing around on my machine it seems that pinning tge version to a newish version seems to resolve this. I'll push a commit for that now.
And I think we are finally done! Thanks @aelanman . Heroic levels of perseverance with this one.
Thanks @jrs65 !
Make compatible with aioredis version 2.