search

chime-experiment / comet

A Config and Metadata Tracker
0 stars 3 forks source link

feat(thread_id): add logging adapter for thread ids #64

Closed anjakefala closed 4 years ago

anjakefala commented 4 years ago

Making this available for testing! This is a prototype, that works in isolation, but I would like to ensure it has a good relationship with the other logging.

jrs65 commented 4 years ago

Looks awesome. Doesn't build but I think that can be fixed up while Rick is merging.

nritsche commented 4 years ago

@anjakefala Can you add the comment Richard requested?

anjakefala commented 4 years ago

@nritsche @jrs65 I added the requested comments, and erased the commented-out code!

There seems to be a lot more stuff in this PR than there was before... =) I leave it to your discretion for whether that is expected and okay to merge.

nritsche commented 4 years ago

@nritsche @jrs65 I added the requested comments, and erased the commented-out code!

Thanks!

There seems to be a lot more stuff in this PR than there was before... =) I leave it to your discretion for whether that is expected and okay to merge.

Yeah, it's just that Richards branches where based on this, so I thought the easiest way is to just merge it back together this way.

anjakefala commented 4 years ago

:crossed_fingers:

anjakefala commented 4 years ago 
[2019-12-12 20:12:04 +0000] - (sanic.access)[INFO][127.0.0.1:56290]: POST http://localhost:4444/send-state  200 20

2019-12-12 20:12:04,069 [8332] [sanic.access:INFO] [request=784736408626] 

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

The build has been terminated
nritsche commented 4 years ago 
Illegal instruction (core dumped)

Progress?

anjakefala commented 4 years ago

What did you do?? @nritsche

nritsche commented 4 years ago

I just executed that test binary directly instead of letting python do it (which hid the output).

anjakefala commented 4 years ago

It seems...happy.

Do we merge? =)

nritsche commented 4 years ago

Oh I didn't noticed it passed. I think either travis is giving us different nodes some times or they are fiddling around with their settings atm.

nritsche commented 4 years ago

Let me fix up the changes I was making on kotekan side. If it keeps passing, yes!