nritsche commented 4 years ago

Solved by making the lru_cached functions raise Exceptions instead of returning None in case they don't find what was requested and telling the lru_cache to not cache exceptions.

Closes #87

codecov[bot] commented 4 years ago

Codecov Report

Merging #88 into master will increase coverage by 2.24%. The diff coverage is 82.22%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   67.13%   69.37%   +2.24%     
==========================================
  Files          10       10              
  Lines         934      947      +13     
==========================================
+ Hits          627      657      +30     
+ Misses        307      290      -17

Impacted Files	Coverage Δ
comet/dataset.py	`88.88% <ø> (ø)`
comet/broker.py	`75.06% <80.48%> (+5.11%)`	:arrow_up:
comet/exception.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b59dbfa...0619923. Read the comment docs.

nritsche commented 4 years ago

It looks like the travis tests were successful, but it didn't report back: https://travis-ci.org/github/chime-experiment/comet/builds/732358709

And codecov doesn't seem to work properly yet.

chime-experiment / comet

fix(broker): datasets get cached as not found permanently #88

Codecov Report