search

chime-experiment / dias

A data integrity framework
https://dias.readthedocs.io/
GNU General Public License v3.0
2 stars 0 forks source link

fix number time frames #155

Closed saurabh-astro closed 4 years ago

saurabh-astro commented 4 years ago

A bug fix, where start and stop times for each file is used to determine number of time frames to be read. Since time_delta is specified in the Finder, current fix is simply using the start and end times of the files listed by Finder. In future, we may want a more careful selection of frames based on the span of source in a given file.

nritsche commented 4 years ago

What is the bug?

anjakefala commented 4 years ago

Stacktrace!

May 20 16:24:20 marimba dias[27498]: [2020-05-20 23:24:20,252] dias[source_spectra]: Processing Pol XX
May 20 16:24:21 marimba dias[27498]: [2020-05-20 23:24:21,409] dias[source_spectra]: Processing Pol YY
May 20 16:24:22 marimba dias[27498]: [2020-05-20 23:24:22,437] dias[source_spectra]: Took 8.1 seconds to process this block.
May 20 16:28:03 marimba dias[27498]: /usr/local/lib/python3.7/dist-packages/scipy-1.4.1-py3.7-linux-x86_64.egg/scipy/optimize/minpack.py:808: OptimizeWarning: Covariance of the parameters could no
May 20 16:28:03 marimba dias[27498]:   category=OptimizeWarning)
May 20 16:28:03 marimba dias[27498]: 10.5.0.11 - - [20/May/2020 23:26:42] "GET /metrics HTTP/1.1" 200 15116
May 20 16:28:03 marimba dias[27498]: [2020-05-20 23:28:03,860] dias[source_spectra]: Writing /mnt/gong/dias/data/source_spectra/cyg_a_csd_2384_source.h5...
May 20 16:28:04 marimba dias[27498]: [2020-05-20 23:28:04,022] dias[source_spectra]: File for CYG_A successfully written out.
May 20 16:28:04 marimba dias[27498]: [2020-05-20 23:28:04,086] dias[source_spectra]: Task failed: list index out of range
May 20 16:28:04 marimba dias[27498]: [2020-05-20 23:28:04,086] dias[source_spectra]: Traceback (most recent call last):
May 20 16:28:04 marimba dias[27498]:   File "/usr/local/lib/python3.7/dist-packages/dias/task.py", line 229, in runner
May 20 16:28:04 marimba dias[27498]:     result = self.analyzer.run()
May 20 16:28:04 marimba dias[27498]:   File "/usr/local/lib/python3.7/dist-packages/dias/analyzers/source_spectra_analyzer.py", line 356, in run
May 20 16:28:04 marimba dias[27498]:     source_start_time, source_stop_time = file_list[file_index][1]
May 20 16:28:04 marimba dias[27498]: IndexError: list index out of range
saurabh-astro commented 4 years ago

What is the bug?

It's essentially computing how many time-frames to load in a file. It was using start and stop times from Finder which was not right. Now it's doing that from the timestamps in the file.