chime-experiment / dias

A data integrity framework
https://dias.readthedocs.io/
GNU General Public License v3.0
2 stars 0 forks source link

fix(ringmaps): be explicit about requiring write permissions for file #178

Closed anjakefala closed 3 years ago

anjakefala commented 3 years ago

h5py version 3 switched the default file open to be r instead of w+

jrs65 commented 3 years ago

It might be worth grepping the rest of the dias/theremin code base to see if there any other places this occurs. I've just looked through the pipeline code to see if it happens and the only occurrences are in abandoned scripts.

anjakefala commented 3 years ago

I did so for dias! @jrs65 This was the only place.

Good point, I will do so for theremin.

anjakefala commented 3 years ago

Theremin is entirely explicit reads. =)