Feat/withdrawqueue

[chimera-defi]

can u take a look at the reference here @devlancer412 and see if you can impl it for this use case? its pretty well defined, and has some reference code https://github.com/ethereum/ERCs/blob/fdec97db783f425b88b7ec22093600f23c5879ab/ERCS/erc-7540.md

[devlancer412]

@chimera-defi I added pushSgEth, pushWsgEth function from your feedback. Please check

[chimera-defi]

did you take a look at erc7540 @devlancer412 ?

[devlancer412]

@chimera-defi Could you check current contract?

[chimera-defi]

TODO:

• security - plz make sure there are no exploit avenues to the best of your knowledge
• deploy script - try to deploy locally via anvil fork. readme instructions should work.
• test
• also left 2 comments here thanks! cc @devlancer412 for viz

[chimera-defi]

wrt the deploy script, try to run this first

npx hardhat run --network localhost deploy/v2/1_deploy_minterv2.js 

then swap out the withdrawal contract deployed there ^, with your new one. i.e. deploy both, onchain do a transfer ownership, so the system deployed in step 1 uses this new WithdrawalQueue

[devlancer412]

@chimera-defi Please check current contract. also added test script and modified deploy script

[devlancer412]

I've checked transfer function to the minter contract. actually it should be work correctly. seems like sth went wrong on development kit. As you know, ethers use bigint instead of BigNumber in v6. This error comes from incompatible packages when serialize bigint. Could we upgrade current development kit with updated ethers, typescript and typechain. I also had some trouble when testing this old packages such as tokenBalanceChange and ethBalanceChange.

@chimera-defi

[chimera-defi]

@devlancer412 sure yea give it a shot plz! see if you can upgrade the packages. feel free to remove any were not using /that are deprecated to make it work as well.

also can you create a new branch off of master and close this one please?