search

chimera-linux / sd-tools

Standalone, cleaned up utilities from systemd
13 stars 0 forks source link

test-sysusers/unhappy-1: test error on 32-bit architectures #1

Open fossdd opened 1 week ago

fossdd commented 1 week ago

Testing sd-tools on 32-bit architectures (armhf, armv7, x86) fails at unhappy-1 test:

*** Running test /tmp/sd-tools/test/test-sysusers/unhappy-1.input
--- /tmp/tmp.DMbCbH/err
+++ /tmp/sd-tools/test/test-sysusers/unhappy-1.expected-err
@@ -1 +1 @@
- Failed to parse UID: '9999999999': No such device or address
+ Failed to parse UID: '9999999999': Result not representable
**** Unexpected error output for /tmp/sd-tools/test/test-sysusers/unhappy-1.input
 Failed to parse UID: '9999999999': No such device or address

AFAIK it seems to be a sd-tools error and not a packaging error. (https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/71413)

nekopsykose commented 1 week ago

this is caused by the different message of https://github.com/chimera-linux/sd-tools/blob/7aac5dd52b37188aef53c7ff0e2b8f295744903c/src/shared/user-util.c#L63 , the actual failure is harmless

seems to be regressed in the port from systemd internal libs as upstream this is not a possible case https://github.com/systemd/systemd/blob/5d6d2d6ced3c1c499e2c369627c8f4d1927e9952/src/basic/user-util.c#L66

nekopsykose commented 1 week ago

(in systemd the parse will always give ERANGE and that's what the test expects there)