search

chimericdream / minekea

Minecraft mod to add a variety of vanilla-esque decorative and functional blocks.
https://www.curseforge.com/minecraft/mc-mods/minekea-fabric
MIT License
4 stars 2 forks source link

Server disconnect issue #47

Closed TheButterbrotMan closed 2 years ago

TheButterbrotMan commented 2 years ago

When i add this mod to my modpack and load a world on a server, i cant connect to it. I am getting this error unknown :

TheButterbrotMan commented 2 years ago

No log needed, there is just this error and then disconnects. Tooked hours for me to troubleshoot removed 200 mods by hand.

chimericdream commented 2 years ago

Well that's obviously not ideal. Thank you for reporting it!

If the pack is public, can you provide a link? If not, do you mind uploading a zip that I can import into the Curse launcher so I can test? Which version of Minecraft and Minekea are you on when you get the error?

TheButterbrotMan commented 2 years ago

https://www.curseforge.com/minecraft/modpacks/deathdusk

TheButterbrotMan commented 2 years ago

Its version 1.18.2, on fabric, with modversion 2.8.2.

TheButterbrotMan commented 2 years ago

I can also confirm other modpacks have this problem.

Version 2.0.9 of my modpack is working. But if you upgrade minekea, you cant create a server.

TheButterbrotMan commented 2 years ago

Some players was also able to produce this bug with the current 2.0.9 version of my modpack. But i was unable to reproduce it.

chimericdream commented 2 years ago

Thanks for the info. There was a short window where I had pushed out a 2.8.x version of the mod which tried to call client code on the server, but I have since archived that file and pushed an update. It's possible that the people who can reproduce the bug on the current version of your pack may have updated the mod independently during that time frame, but obviously impossible to know for certain.

Either way, I will install your pack tonight, update Minekea, and see what I need to do to push a fix as soon as I can.

chimericdream commented 2 years ago

Unfortunately, I'm not sure that Minekea is the cause of this. I started my testing a few minutes ago, and I downloaded both the server and client for v2.0.9 of the pack. I tried to connect to the server and got the error exactly as you described. Then I tried disabling Minekea, and the error was still present. I didn't make any changes to the default configs, the server.properties, or anything besides disabling the Minekea jar file.

2022-06-16 21_53_01-mods

2022-06-16 21_50_20-Deathdusk

I will leave this open in case you have a way for me to reproduce the error showing that Minekea is definitely the culprit.

chimericdream commented 2 years ago

Actually, I may have just figured out the issue. It may be caused by the sheer volume of recipes in the pack. I tried searching for the error message, and I found this issue in the Forge repository. I realize that this is a Fabric mod and modpack, but I can't help wondering if Fabric has the same limitation.

https://github.com/MinecraftForge/MinecraftForge/issues/6703

As a matter of fact, it looks like this might be a bug in Minecraft itself:

https://bugs.mojang.com/browse/MC-185901

TheButterbrotMan commented 2 years ago

Try with 2.0.10, and update minekea to latest update there. This should make it reproduce able.

If it is this recipe bug,any idea how I could fix it?

chimericdream commented 2 years ago

The issue for me is that I can reproduce the crash both with and without my mod. If it is indeed a bug in Minecraft itself caused by too many recipes, there may not be a fix available other than finding a way to reduce the overall count (which basically means removing mods, as much as I hate to say it).

It might be worth posting this in the FabricMC issue tracker to see if there's anything that can be done within the loader itself similar to what Forge did in the link above. I will try to get that created tonight, unless you want to do it.

chimericdream commented 2 years ago

@TheButterbrotMan I just created an issue in the Fabric repo. Here's hoping!

TheButterbrotMan commented 2 years ago

Thank you! :)

chimericdream commented 2 years ago

@TheButterbrotMan since there isn't anything specific to Minekea that we were able to determine, I am going to go ahead and close this. If it is still a problem after the recent changes to the NBT Crafting mod, and you're able to determine that there is something about Minekea in particular that causes the bug, we can reopen it.