Open chimwemwe007 opened 6 months ago
Good job so far ππ» There are some issues that you still need to work on your project but you are almost there!
Backlog
column instead Done column, right now your tasks are already in the Done
column which means that you already did everything without the approval of the code reviewer, because it is a kanban board setup task, you should add everything in the first column and as per the instructions.Check the comments under the review.
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag @skyv26 in your question so I can receive the notification. You can also follow me on the below platforms
|
|
|
|
![]() |
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
This issue has been resolved.
Hi @chimwemwe007,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Note: Please, you can now Merge since it is Approved β , However if there are any conflicts please resolve them before merging.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this issue the following milestones were completed.
link to Kanban board: https://github.com/users/chimwemwe007/projects/12