Closed ncarboni closed 4 years ago
Thank you @ncarboni for raising the issue.
I just fixed the IndexError by editing the regex expression to find the classes. The previous expression only took into account classes with crm:
prefix, thus missing out other prefixes such as frbroo
.
However, there are a few things you need to edit on your end:
E33_E41_Linguistic_Appellation
wasn't defined in cidoc crm rdf in ./src/ontologies
.E15
should be Identifier_Assignment not Type_Assignment in your .ttl, otherwise you should edit cidoc crm rdf instead.https://www.srdm.org/name/fie_17_1
should be https://www.srdm.org/type/fie_17_1
.<http://iflastandards.info/ns/fr/frbr/frbroo/>
was hardcoded as frbroo, instead of frbr
, so you should also update this in your .ttl. I'm planning to eventually update this issue so that the script can use the prefixes defined in the input turtle. Thank you @ncarboni for raising the issue. I just fixed the IndexError by editing the regex expression to find the classes. The previous expression only took into account classes with
crm:
prefix, thus missing out other prefixes such asfrbroo
.However, there are a few things you need to edit on your end:
make sure the classes you use in your turtle match with the ontologies' rdf files. For instance:
E33_E41_Linguistic_Appellation
wasn't defined in cidoc crm rdf in./src/ontologies
.E15
should be Identifier_Assignment not Type_Assignment in your .ttl, otherwise you should edit cidoc crm rdf instead.- I suspect that
https://www.srdm.org/name/fie_17_1
should behttps://www.srdm.org/type/fie_17_1
.- In the script, the prefix for
<http://iflastandards.info/ns/fr/frbr/frbroo/>
was hardcoded as frbroo, instead offrbr
, so you should also update this in your .ttl. I'm planning to eventually update this issue so that the script can use the prefixes defined in the input turtle.
Thank you! I only checked if the syntax was ok and indeed I did not noticed the errors. I will have to go through all the turtle and reconstruct them a bit.. but that aside, it works perfectly now! :-) Thanks!
I am testing the script and it works great with type instances. I have problems, however, in using with the type "ontology". If I use the command
python criteria.py ontology turtle_name.ttl names.mmd
What I get isthe content of turtle_name.ttl is:
Any ideas what the problem is?