Bugs fixes and feature enhancements to pb4php 0.1

[GoogleCodeExporter]

Below are the code changes of the attached file:

1. The 'import' and 'package' specifiers is supported in 
parser/pb_parser.php
2. Added bytes scalar types to parser/pb_parser.php
3. Fixed a bug in the set_value() function in 
message/encoding/pb_base128.php
   - If the length of $newstring is larger than 32, the following lines 
will result in an integer overflow. Avoid to use bindec() in this case.
     $hexstring = dechex(bindec($newstring));
4. Fixed a bug in the SerializeToString() function in 
message/pb_message.php
   - Use strlen($stringinner) instead of mb_strlen($stringinner), or the 
length might be incorrect if the internal character encoding is UTF8 or 
others.
5. Replace the name of WIRED_STRING with WIRED_LENGTH_DELIMITED, which 
would be a proper name announced by Google.
6. Remove the 'var_dump()' code from message/type/pb_bool.php

Original issue reported on code.google.com by che...@gmail.com on 5 Mar 2009 at 3:45

Attachments:

• protobuf-0.1-20090305-cheton.zip

[GoogleCodeExporter]

bravo, this solved my long long headache issue

Original comment by aql...@gmail.com on 5 Mar 2009 at 3:52

[GoogleCodeExporter]

Sorry, fixed a typo in above report list:

Original one:
"If the length of $newstring is larger than 32, ..."

New one:
"If the length of $newstring is larger than 32*8, ..."

Original comment by che...@gmail.com on 5 Mar 2009 at 3:56

[GoogleCodeExporter]

[25]

Original comment by kordu...@googlemail.com on 23 Mar 2009 at 7:11

• Changed state: Fixed

[GoogleCodeExporter]

r25 r26 - slightly changed the interface from append_primitive('pr') to
add_primitive('pr') ... so its no difference between primitives and not.

Original comment by kordu...@googlemail.com on 23 Mar 2009 at 7:35

[GoogleCodeExporter]

i removed the changes from the parser cause the interface change is too big. 
for all
other thank to cheton

Original comment by kordu...@googlemail.com on 23 Mar 2009 at 8:21