Closed chinchang closed 8 years ago
Hey @tfoxy, I have used a similar technique you had suggested in #81, to support both attributes. Would be great if you could review this.
I tested it and I think this PR is great.
I would suggest mentioning aria-label
in the readme, saying that this is preferred instead of data-hint
, as the former has support for screen readers.
@tfoxy Yeah. Will update the docs.
@chinchang Do you know if this will make it into the next release / when that will be!? This really would be a great feature to have!
@rossholdway I am working on the final changes for this to get merged into master. This will be live in the coming release this weekend.
Merging into dev.
Carrying forward @jdan original PR #128 to support screen reader a11y by using
aria-label
attribute.Copy from #128:
This PR now puts in default support for
aria-label
attribute to define tooltip content along with the currently supporteddata-hint
attribute. So any of the attributes will work.Opening this PR against
dev
where I can finally work on the related docs and examples for this to get ready formaster
.Note: Ignore the CSS files in the diff :)