search

chinchang / hint.css

A CSS only tooltip library for your lovely websites.
https://kushagra.dev/lab/hint/
MIT License
8.42k stars 701 forks source link

More modular CSS? #80

Closed lewisnyman closed 10 years ago

lewisnyman commented 10 years ago

Hi,

Thanks for writing this plugin. I'm working on integrating it into Drupal core at the moment. https://drupal.org/node/2207383

One of the problems with implementation is that the hint.css contains a lot of "non-functional" styling that we have to override to get looking right with our themes. The Drupal project doesn't use Sass and it's not a good idea to start chopping up the CSS file for maintenance reasons.

If we can agree on a direction I'm happy to do the leg work. Does it make sense to compile a hint.base.css file that contains just the functional stuff without any fancy shadows etc?

chinchang commented 10 years ago

Hey @lewisnyman That sounds like a good idea. Will certainly be useful when theming is not wanted in the library. I'll look into this and as a first step I'll compile a list of things which can be counted as 'theme' and thus removed from the base build.

lewisnyman commented 10 years ago

Great! :) If it helps, I would probably file the following under theming: hint-color-types.scss hint-rounded.scss hint-effects.scss

As well as a few minor .hint properties like text-shadow and box-shadow.

chinchang commented 10 years ago

WIP branch:

Source: https://github.com/chinchang/hint.css/blob/add-a-base-build/src/hint.base.scss Build: https://github.com/chinchang/hint.css/blob/add-a-base-build/hint.base.css

Will make the required build process changes next and update.

lewisnyman commented 10 years ago

This is great :) So useful

chinchang commented 10 years ago

@lewisnyman This is live in v1.3.3. You get extra hint.base.css and hint.base.min.css now :)