search

chinchang / web-maker

A blazing fast & offline frontend playground
https://webmaker.app
MIT License
2.56k stars 316 forks source link

Added cursor pointer to buttons and links in the footer #390

Closed PaulvdDool closed 11 months ago

PaulvdDool commented 5 years ago

Footer buttons and links had the default cursor on hover.

See link below for GIF with changes: https://jmp.sh/yb1a0rR

chinchang commented 5 years ago

Thanks for contributing @PaulvdDool. I reviewed your changes and have a few points:

  1. The cursor change on <a> isn't required. <a> already has pointer cursor.
  2. I am curious about the reason for changing the cursor on <button>. Is it something you felt the need for or just a convention you follow?
julientaq commented 5 years ago

This question is a really complex one. Normally button should not have pointer, as W3C explain that the pointer should show a link. From a user perspective, we started to get used to have the pointer to anything that could get clickable. But it's not an easy choice and I just wanted to be sure that both of you had read this article before merging the changes:

https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b

chinchang commented 11 months ago

Thanks for the contribution @PaulvdDool 🙇 This took a while to get merged 😅 PS: merged it manually since it was out of date