search

chinchang / web-maker

A blazing fast & offline frontend playground
https://webmaker.app
MIT License
2.55k stars 314 forks source link

Should add node engine in pacakge.json #476

Closed MDAkramSiddiqui closed 2 years ago

MDAkramSiddiqui commented 2 years ago

* SUGGESTION

Install issue with node 12.22.1

node-pre-gyp ERR! node -v v12.22.7
node-pre-gyp ERR! node-pre-gyp -v v0.12.0
node-pre-gyp ERR! not ok 
Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --library=static_library --module=/

Worked perfectly with 10.22.1

So it would be good to strictly mention the node version in pacakge.json.