search

chinchang / web-maker

A blazing fast & offline frontend playground
https://webmaker.app
MIT License
2.55k stars 314 forks source link

(v5) fix top header buttons misaligned #501

Closed arnabsen1729 closed 2 years ago

arnabsen1729 commented 2 years ago

Fixes: #498

Ideally, we would want the bundler to bundle the CSS files, and hence we should include the stylesheets in the index.js. So we can remove the linked CSS files in the index.html.

The main issue regarding the misalignment was that style.css was being overridden by hint.min.css. There was one import of the style.css in src/components/app.jsx which was the culprit. So removed it from there and put it together with the other imports in the index.js. Also maintained the order such that style.css is not overridden anymore. This fixes the alignment issue.

Before image

After image

chinchang commented 2 years ago

Very nice description put in the PR @arnabsen1729! That's the way! 👏🏼 🔥