Fix issue 546: Tab key not working in JS editor when using CodeMirror

chinchang / web-maker

A blazing fast & offline frontend playground

https://webmaker.app

MIT License

2.54k stars 314 forks source link

Closed nhogle closed 9 months ago

nhogle commented 9 months ago

The check for the Emmet option was short-circuiting the logic for inserting a Tab. Note that the emmet option is only enabled on HTML and CSS editors, (and not the JS editor), which is why the Tab key works in those editors, but not the JS editor.

chinchang commented 9 months ago

Great! This is a nice fix. Thanks @nhogle 🙏