search

chinchin96 / SublimeText-Merge-Windows

This Plugin allows the merging of all tabs in separate windows into a single window in SublimeText 3
23 stars 4 forks source link

inserts extra indentation #2

Open MarredCheese opened 7 years ago

MarredCheese commented 7 years ago

I just installed this. I foolishly tried it for the first time without backing anything up. It rearranged the tabs in a seemingly random order and damaged many (but not all) of the tabs that were open. Most of the tabs were files only existing inside of Sublime, if relevant.

Before example:

file
looked
like
this
for
hundreds
of
lines

After example (sometimes extra-indented with spaces, sometimes with tabs, depending on how the original file was indented, I assume):

file
           looked
                       like
                                   this
                                               for
                                                           hundreds
                                                                          of
                                                                                       lines
chinchin96 commented 7 years ago

Sorry mmarchese1. It's not your fault. I too saw the same thing early on but thought I had fixed it. Do you know if the affected files were saved to disk or just a working document you had open?

Chinedu Ezeamuzie 404-514-7910

From: mmarchese1 notifications@github.com Sent: Tuesday, October 10, 2017 9:55:22 PM To: chinchin96/SublimeText-Merge-Windows Cc: Subscribed Subject: [chinchin96/SublimeText-Merge-Windows] inserts tabs and lines (#2)

I just installed this. I foolishly tried it for the first time without backing anything up and while I only had one window open to see what would happen. It rearranged the tabs in a seemingly random order and damaged many (but not all) of the tabs that were open. Most of the tabs were files only existing inside of Sublime, if relevant.

Before example:

file looked like this for hundreds of lines

After example (but with tabs in reality, not spaces as shown here):

file looked like this for hundreds of lines

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/chinchin96/SublimeText-Merge-Windows/issues/2, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACZiBDaBFh_-RRwGoaDlcw0mcq7V9B-Rks5srCAJgaJpZM4P0zvM.

MarredCheese commented 7 years ago

I think they were all working files not yet saved to disk.

On Sun, Oct 15, 2017 at 9:58 PM, chinchin96 notifications@github.com wrote:

Sorry mmarchese1. It's not your fault. I too saw the same thing early on but thought I had fixed it. Do you know if the affected files were saved to disk or just a working document you had open?

Chinedu Ezeamuzie 404-514-7910 <(404)%20514-7910>

From: mmarchese1 notifications@github.com Sent: Tuesday, October 10, 2017 9:55:22 PM To: chinchin96/SublimeText-Merge-Windows Cc: Subscribed Subject: [chinchin96/SublimeText-Merge-Windows] inserts tabs and lines (#2)

I just installed this. I foolishly tried it for the first time without backing anything up and while I only had one window open to see what would happen. It rearranged the tabs in a seemingly random order and damaged many (but not all) of the tabs that were open. Most of the tabs were files only existing inside of Sublime, if relevant.

Before example:

file looked like this for hundreds of lines

After example (but with tabs in reality, not spaces as shown here):

file looked like this for hundreds of lines

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ chinchin96/SublimeText-Merge-Windows/issues/2, or mute the thread< https://github.com/notifications/unsubscribe-auth/ACZiBDaBFh_- RRwGoaDlcw0mcq7V9B-Rks5srCAJgaJpZM4P0zvM>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chinchin96/SublimeText-Merge-Windows/issues/2#issuecomment-336767845, or mute the thread https://github.com/notifications/unsubscribe-auth/AO-LbIvcDMdVVcs32s4DEv8DejHpsMIGks5sssY4gaJpZM4P0zvM .

chinchin96 commented 7 years ago

Ahh, ok. I may need to take a look at that again. Does it work with saved files?

Chinedu Ezeamuzie 404-514-7910

From: mmarchese1 notifications@github.com Sent: Sunday, October 15, 2017 11:05:26 PM To: chinchin96/SublimeText-Merge-Windows Cc: chinchin96; Comment Subject: Re: [chinchin96/SublimeText-Merge-Windows] inserts extra indentation (#2)

I think they were all working files not yet saved to disk.

On Sun, Oct 15, 2017 at 9:58 PM, chinchin96 notifications@github.com wrote:

Sorry mmarchese1. It's not your fault. I too saw the same thing early on but thought I had fixed it. Do you know if the affected files were saved to disk or just a working document you had open?

Chinedu Ezeamuzie 404-514-7910 <(404)%20514-7910>

From: mmarchese1 notifications@github.com Sent: Tuesday, October 10, 2017 9:55:22 PM To: chinchin96/SublimeText-Merge-Windows Cc: Subscribed Subject: [chinchin96/SublimeText-Merge-Windows] inserts tabs and lines (#2)

I just installed this. I foolishly tried it for the first time without backing anything up and while I only had one window open to see what would happen. It rearranged the tabs in a seemingly random order and damaged many (but not all) of the tabs that were open. Most of the tabs were files only existing inside of Sublime, if relevant.

Before example:

file looked like this for hundreds of lines

After example (but with tabs in reality, not spaces as shown here):

file looked like this for hundreds of lines

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ chinchin96/SublimeText-Merge-Windows/issues/2, or mute the thread< https://github.com/notifications/unsubscribe-auth/ACZiBDaBFh_- RRwGoaDlcw0mcq7V9B-Rks5srCAJgaJpZM4P0zvM>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chinchin96/SublimeText-Merge-Windows/issues/2#issuecomment-336767845, or mute the thread https://github.com/notifications/unsubscribe-auth/AO-LbIvcDMdVVcs32s4DEv8DejHpsMIGks5sssY4gaJpZM4P0zvM .

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/chinchin96/SublimeText-Merge-Windows/issues/2#issuecomment-336768784, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACZiBM1LYicDs4XhZevSt2qf1jVU0raoks5sssf2gaJpZM4P0zvM.

nerdCopter commented 4 years ago

same issue. causes difficulty repairing buffers(tabs) after merge windows.

chinchin96 commented 4 years ago

Hey @nerdCopter ,

I'm sorry, but I haven't had time to look into this fix. @FichteFoll or @valerij may be able to help. I know there are some limtations with how Sublime Text handles buffers for this kind of enhancement.

FichteFoll commented 4 years ago

Generally, this kind of error occurs because ST applies smart indentation in cases where it's not expected, which results in indentation levels being automatically maintained while the input has separate tabs for this.

Note that I only looked at the behavior reported in this ticket, not at the actual code.

There are 3 ways to fix this issue:

  1. Use the append command with the disable_tab_translation parameter (only available to ST 4050+).
  2. Disable the auto_indent setting before inserting, then erasing it to the User's default.
  3. Use snippet insertion with a provided variable which somehow circumvents epansion: view.run_command("insert_snippet", {"contents": "$VAR", "VAR": the_text})
nerdCopter commented 4 years ago

@FichteFoll i tried and failed to repair local .zip/.py . Do you have a working fork that i may use?

FichteFoll commented 4 years ago

You'll want to use an override for local patches to packages. See https://docs.sublimetext.io/extensibility/packages.html#customizing-or-overriding-packages and https://github.com/OdatNurd/OverrideAudit.