Closed dbrgn closed 5 years ago
@dbrgn thanks for putting this together!
This main question that comes to mind for me is - what is the use case for being able to create comment nodes?
Thanks!
This main question that comes to mind for me is - what is the use case for being able to create comment nodes?
In my case, trying to work around a browser bug by inserting a comment node after a <br>
element.
Gotcha thanks for the context!
I'll close this for now since I don't currently have the time to continue the development of this feature.
If someone wants to take over, feel free!
Initial draft for adding user defined comment support.
Most of it was straightforward, although some parts should probably be refactored in the future since it's getting boilerplate-y.
The main open question I'm facing right now is in
crates/virtual-dom-rs/src/patch/apply_patches.rs
:How do we deal with the
<!-- ptns -->
comments?