search

chinedufn / percy

Build frontend browser apps with Rust + WebAssembly. Supports server side rendering.
https://chinedufn.github.io/percy/
Apache License 2.0
2.26k stars 84 forks source link

Improved CI #78

Closed dbrgn closed 5 years ago

dbrgn commented 5 years ago

Hi @chinedufn, is it OK if I try to improve our CI pipeline by setting up https://circleci.com/ and splitting up the workflow?

chinedufn commented 5 years ago

@dbrgn absolutely! Anything that improves our CI is a 👍 in my book!

dbrgn commented 5 years ago

Oh wow, the "run all tests" CircleCI build brings the build time from ~9-10 minutes (on TravisCI) down to around 3 minutes. And that's without much optimization. They use incredibly fast machines.

@chinedufn I have an initial version running on my fork. Could you maybe log in at https://circleci.com/add-projects/gh/chinedufn and add a new project for percy? I can't do it myself due to missing permissions.

Right now the tests work, but I'd like to split up unit tests and browser tests if possible. I also need to port over the gh-pages stuff. Maybe you could follow the steps here to create a deploy key, put it into CircleCI and register the public key in this GitHub repo? I'd only to know the fingerprint.

chinedufn commented 5 years ago

Woahhhhhh love it!

Done!

Here's the fingerprint 71:95:d0:f5:0d:f6:fe:2a:9d:62:d7:4e:9a:6f:8e:8d

Right now the tests work, but I'd like to split up unit tests and browser tests if possible.

If we're going from 10 minutes to 3 minutes I certainly have no complaints, but just curious about the thought process here so that I understand?

Nice!