search

chinedufn / percy

Build frontend browser apps with Rust + WebAssembly. Supports server side rendering.
https://chinedufn.github.io/percy/
Apache License 2.0
2.26k stars 84 forks source link

Set up CircleCI #79

Closed dbrgn closed 5 years ago

dbrgn commented 5 years ago

Fixes #78.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

dbrgn commented 5 years ago

@chinedufn ok, this is now ready for review. Tests should pass, and deployment works.

Here's what a successful workflow looks like: https://circleci.com/workflow-run/fd284d94-6a94-4173-b38f-eb67f6f733d3

img

Of course the deployment step only happens when test and docs-build worked, and if it's running on the master branch. (This workflow was really fast due to caching, but also because of the nice build machines and fast network. Probably with some caching layers there too.)

I temporarily disabled the branch filter for a single build, so that a test deployment could get through. At the bottom of https://chinedufn.github.io/percy/introduction.html you can see the "Other" section, that means that the deployment from CircleCI worked.

PS: Did you disable secure variables for forked repositories, as suggested by the guide?

dbrgn commented 5 years ago

Ok, I think all open issues should now have been resolved. Let's hope it still passes the tests :wink: