search

chinedufn / percy

Build frontend browser apps with Rust + WebAssembly. Supports server side rendering.
https://chinedufn.github.io/percy/
Apache License 2.0
2.27k stars 84 forks source link

Store closures for newly appended/replaced nodes #84

Closed chinedufn closed 5 years ago

chinedufn commented 5 years ago

Fixes #70

We weren't holding on to the closures that were created for DOM nodes in the AppendChildren / Replace patches so they just wouldn't work as soon as your VirtualNode got dropped.

dbrgn commented 5 years ago

@chinedufn I wonder if we should disable the now bot for every push, and instead only trigger it for merges into master (in case that's possible)...

chinedufn commented 5 years ago

@dbrgn the original idea was to be able to easily add updates to the demo over time and have a reviewer see and play with them...

But it seems like now.sh's is moving moving away from their Docker offering so we can expect it to continue to break like this.

Building on PRs isn't a requirement - but finding a new way to automatically deploy the isomorphic demo somewhere on master builds would be nice. Do you know if any alternative services here that are easy to get set up with?

I don't see any options for disabling it on PRs but if there's some other easy way to easily continuously deploy our basic Rust server I can switch to it. Haven't looked into this yet...

chinedufn commented 5 years ago

Merging, let me know if you want anything changed!

chinedufn commented 5 years ago

Uninstalled now.sh.

Planning to replace it isomorphic server live example with a live client side example so that we don't have to worry as much about deployment and can just use GitHub Pages.

dbrgn commented 5 years ago

Sounds good!