search

chinedufn / percy

Build frontend browser apps with Rust + WebAssembly. Supports server side rendering.
https://chinedufn.github.io/percy/
Apache License 2.0
2.27k stars 84 forks source link

Rename props with attrs #89

Closed ghost closed 5 years ago

ghost commented 5 years ago

While reading source code of virtual_dom_rs, I was confused by VElement's props. the term "properties" and "attributes" has slightly different meanings in DOM. VElement's one named props but what it contains is "attributes" rather than "properties" I think.

Fixes #77

ghost commented 5 years ago

oh I totally forgot about those... fixed it.

chinedufn commented 5 years ago

Thanks so much !!!